fix: export mktime and strftime from bare use POSIX#684
Merged
Conversation
Stock Perl puts `mktime` in POSIX's default `@EXPORT`, so CPAN code that does `use POSIX` and calls `mktime` works. PerlOnJava's trimmed default export list omitted it, breaking Astro::SunTime (and any similar caller). Also export `strftime`, which is another default time export on core Perl and is implemented here. Fixes `./jcpan -t Astro::SunTime`. Generated with [Cursor](https://cursor.com) Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stock Perl’s
POSIXmodule putsmktimein the default export list, so code that doesuse POSIXand calls baremktimeworks. PerlOnJava’sPOSIXused a trimmed@EXPORTand omittedmktime, which broke Astro::SunTime (Undefined subroutine &Astro::SunTime::mktime).strftimeis also a common default export on core Perl and is implemented here, so it is included for the same compatibility reason.Testing
make./jcpan -t Astro::SunTime(all tests pass)